Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Publish without node-pty dependency #585

Merged
merged 5 commits into from
Jul 13, 2023
Merged

Publish without node-pty dependency #585

merged 5 commits into from
Jul 13, 2023

Conversation

chrmarti
Copy link
Contributor

@chrmarti chrmarti commented Jul 4, 2023 •
edited
Loading

@chrmarti chrmarti force-pushed the chrmarti/familiar-chicken branch 2 times, most recently from dd65fec to 9cc516f Compare July 4, 2023 13:10
@chrmarti chrmarti changed the title Optional node-pty Publish without node-pty dependency Jul 12, 2023
@chrmarti chrmarti marked this pull request as ready for review July 13, 2023 12:33
@chrmarti chrmarti requested a review from a team as a code owner July 13, 2023 12:33
joshspicer
joshspicer approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - I think this will require some extra testing in Codespaces once published. Do you anticipate any other changes we'll need to make to pick this up?

@chrmarti
Copy link
Contributor Author

@joshspicer From what I saw you install node-pty separately before you install the CLI and I think that might make everything continue to work as before. 🤞

@chrmarti chrmarti merged commit 87e38d1 into main Jul 13, 2023
37 checks passed
@chrmarti chrmarti deleted the chrmarti/familiar-chicken branch July 13, 2023 19:36
@ZauberNerd ZauberNerd mentioned this pull request Aug 28, 2023
Draft
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshspicer joshspicer joshspicer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chrmarti @joshspicer