Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: add generate-docs subcommand #759

Merged
merged 2 commits into from
Mar 11, 2024

Conversation

hellodword
Copy link
Contributor

Discussed with @samruddhikhandale in this issue: devcontainers/action#212

And added a test-container-features-cli script for fast test, the test-container-features costs a lot of time locally.

@hellodword hellodword requested a review from a team as a code owner February 16, 2024 05:55
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool, thank you so much for taking the time to contribute this change 🎉

Works like a charm!

image

src/spec-node/devContainersSpecCLI.ts Outdated Show resolved Hide resolved
src/spec-node/devContainersSpecCLI.ts Outdated Show resolved Hide resolved
src/spec-node/collectionCommonUtils/genDocsCommandImpl.ts Outdated Show resolved Hide resolved
src/spec-node/featuresCLI/genDocs.ts Outdated Show resolved Hide resolved
src/spec-node/templatesCLI/genDocs.ts Outdated Show resolved Hide resolved
@hellodword
Copy link
Contributor Author

And I added gitHubOwner and gitHubRepo to keep the same result

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing, let's wait for another review from @chrmarti
Thanks again! 🎉

@hellodword hellodword changed the title Feat: add gen-docs subcommand Feat: add generate-docs subcommand Feb 27, 2024
@hellodword
Copy link
Contributor Author

Force pushed to modify the commit message

Copy link
Contributor

@chrmarti chrmarti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@samruddhikhandale samruddhikhandale merged commit 10b0ec5 into devcontainers:main Mar 11, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants