Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The github-cli feature does not work with non-debian based images. #360

Closed
aetos382 opened this issue Dec 26, 2022 · 1 comment
Closed
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@aetos382
Copy link

Since bash or apt-get is used in install.sh, it will not work on distributions that do not have these commands.
I would like to have this clearly stated in the documentation.

#!/usr/bin/env bash

apt_get_update()
{
if [ "$(find /var/lib/apt/lists/* | wc -l)" = "0" ]; then
echo "Running apt-get update..."
apt-get update -y
fi
}

@joshspicer
Copy link
Member

joshspicer commented Dec 27, 2022

Thanks for pointing this out. A note about this used to be in the repo's README, but was removed recently. I'll add a comment to each individual Feature's README expressing its compatibility.


With the exception of the common-utils Feature, all Features in this repo target debian-based distros. That said, Features themselves can be written to target any linux distribution.

The reason this repo targets mostly debian distros it to keep maintainability simple for our team. We encourage others to write their own Features if they identify a gap in what's offered in this repo.

relevant to: devcontainers/spec#58

@joshspicer joshspicer self-assigned this Dec 27, 2022
@joshspicer joshspicer added the documentation Improvements or additions to documentation label Dec 27, 2022
joshspicer added a commit that referenced this issue Dec 27, 2022
* #360

* omit from common utils
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants