dotnet lts fix #1003
Open
dotnet lts fix #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samruddhikhandale
requested changes
Jun 18, 2024
sliekens
reviewed
Jun 21, 2024
sliekens
suggested changes
Jul 16, 2024
| @@ -6,7 +6,7 @@ | |||
| # | |||
| # Docs: https://github.com/devcontainers/features/tree/main/src/dotnet | |||
| # Maintainer: The Dev Container spec maintainers | |||
| DOTNET_VERSION="${VERSION:-"latest"}" | |||
| DOTNET_VERSION="${VERSION:-"lts"}" | |||
There was a problem hiding this comment.
I'm not sure if this was just for testing but otherwise I wouldn't change the default version
| @@ -105,7 +105,7 @@ done | |||
|
|
|||
| # Install .NET versions and dependencies | |||
| # icu-devtools includes dependencies for .NET | |||
| check_packages wget ca-certificates icu-devtools | |||
| check_packages wget ca-certificates icu-devtools curl jq | |||
There was a problem hiding this comment.
Perhaps you could drop curl and only use wget for consistency with existing code
| @@ -12,6 +12,9 @@ fetch_latest_version_in_channel() { | |||
| wget -qO- "https://dotnetcli.azureedge.net/dotnet/Runtime/$channel/latest.version" | |||
| elif [ "$runtime" = "aspnetcore" ]; then | |||
| wget -qO- "https://dotnetcli.azureedge.net/dotnet/aspnetcore/Runtime/$channel/latest.version" | |||
| elif [ "$channel" = "LTS" ]; then | |||
| echo $(curl -s https://dotnetcli.blob.core.windows.net/dotnet/release-metadata/releases-index.json | | |||
There was a problem hiding this comment.
I am thinking it would be good to replace all usages of latest.version with release-index.json for consistency, and because using the latest.version file in scripts is not endorsed by the .NET team
| @@ -87,7 +87,7 @@ | |||
| "remoteUser": "vscode", | |||
| "features": { | |||
| "dotnet": { | |||
| "version": "latest", | |||
| "version": "lts", | |||
There was a problem hiding this comment.
Same remark, if not needed for testing, I would revert this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue 1000
Feature Name:
Description:
This PR does the following -
Changelog:
Checklist: