Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installing yarn via corepack on Debian-based systems, too #1009

Merged

Conversation

hoechenberger
Copy link
Contributor

@hoechenberger hoechenberger commented Jun 19, 2024

The default behavior remains unchanged, but Debian and Ubuntu users can now opt-out from the APT-based installation to get the latest yarn via corepack.

Closes #1004

The default behavior remains unchanged, but users can now opt-out from the APT-based installation to get the latest `yarn` via `corepack`.

Closes devcontainers#1004
@hoechenberger hoechenberger requested a review from a team as a code owner June 19, 2024 09:24
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense, thanks!

Left couple of comments

src/node/devcontainer-feature.json Outdated Show resolved Hide resolved
src/node/devcontainer-feature.json Outdated Show resolved Hide resolved
src/node/install.sh Outdated Show resolved Hide resolved
src/node/install.sh Outdated Show resolved Hide resolved
hoechenberger and others added 4 commits June 19, 2024 22:26
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
@hoechenberger
Copy link
Contributor Author

@samruddhikhandale I believe I've addressed all your comments. Unfortunately I currently cannot run the test case locally, so we'll have to rely on the CI output

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

src/node/devcontainer-feature.json Outdated Show resolved Hide resolved
@samruddhikhandale samruddhikhandale merged commit 62f7f7f into devcontainers:main Jun 20, 2024
10 of 11 checks passed
@hoechenberger hoechenberger deleted the hoechenberger/issue1004 branch June 21, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants