-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow installing yarn
via corepack
on Debian-based systems, too
#1009
Allow installing yarn
via corepack
on Debian-based systems, too
#1009
Conversation
The default behavior remains unchanged, but users can now opt-out from the APT-based installation to get the latest `yarn` via `corepack`. Closes devcontainers#1004
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense, thanks!
Left couple of comments
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
@samruddhikhandale I believe I've addressed all your comments. Unfortunately I currently cannot run the test case locally, so we'll have to rely on the CI output |
c57d823
to
f8c6dcb
Compare
f8c6dcb
to
507ac15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
The default behavior remains unchanged, but Debian and Ubuntu users can now opt-out from the APT-based installation to get the latest
yarn
viacorepack
.Closes #1004