[Java] - features issue #1101 - installs -tem instead -ms for lts installation #1021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinyoo
reviewed
Jun 28, 2024
samruddhikhandale
requested changes
Jun 28, 2024
justinyoo
reviewed
Jun 29, 2024
samruddhikhandale
requested changes
Jul 9, 2024
samruddhikhandale
requested changes
Jul 11, 2024
Co-authored-by: Samruddhi Khandale <samruddhikhandale@github.com>
…_for_jdk_lts' into java_ms_instead_tem_for_jdk_lts
| if [ "${requested_version}" = "latest" ] || [ "${requested_version}" = "current" ] || [ "${requested_version}" = "lts" ]; then | ||
| if [ "${requested_version}" = "lts" ]; then | ||
| check_packages jq | ||
| all_lts_versions=$(curl -s https://api.adoptopenjdk.net/v3/info/available_releases) |
There was a problem hiding this comment.
I like the approach of how you are finding the LTS version 🎉
Quick question, who hosts this API? Is it https://adoptium.net/ or someone else?
We need to ensure it is safe to use before we use this approach
| if [ "${requested_version}" = "lts" ]; then | ||
| check_packages jq | ||
| all_lts_versions=$(curl -s https://api.adoptopenjdk.net/v3/info/available_releases) | ||
| major_version=$(echo "$all_lts_versions" | jq -r '.available_lts_releases | sort | .[-1]') |
There was a problem hiding this comment.
Why don't we directly use most_recent_lts property?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature name:
Description:
This PR is for solution to following issue:
Changelog:
install.shChecklist: