Fix installing latest git from PPA in bionic #1056
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trxcllnt
changed the title
|
It appears |
samruddhikhandale
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
keys.openpgp.orgstrips user IDs from keys unless the key owner grants permission to share them. This leads to gpg rejecting the keys instead of importing them, and failing to install thegitfeature.This PR enforces an explicit order when testing and importing keys from the keyservers list, ensuring
keys.openpgp.orgis the last keyserver to be tried. Previously, keyservers were selected based on bash's associative array key enumeration order, but this order is different between Bash v4 (in Ubuntu Bionic) and v5 (Ubuntu Focal+).I believe the issue isn't seen in Bash v5 because the ubuntu keyservers are enumerated first, not because the gpg version in Focal accepts keys without user IDs.
If this is the case, we should either stop attempting to import keys from
keys.openpgp.org, or encourage the owner ofE1DD270288B4E6030699E45FA1715D88E1DF1F24to grantopenpgp.orgpermission to share their user ID.Fixes #1055 and adds a new scenario test.
Note: I believe this fix may need to be applied to all features modified in #1016.