Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update go tools #559

Merged
merged 5 commits into from
May 31, 2023

Conversation

devshun
Copy link
Contributor

@devshun devshun commented May 24, 2023

close #553

updated the Go tools used in features/go.
target: vscode-go v0.38.0

After

GO_TOOLS="\
    golang.org/x/tools/gopls@latest \
    honnef.co/go/tools/cmd/staticcheck@latest \
    golang.org/x/lint/golint@latest \
    github.com/mgechev/revive@latest \
    github.com/go-delve/delve/cmd/dlv@latest \
    github.com/fatih/gomodifytags@latest \
    github.com/haya14busa/goplay/cmd/goplay@latest \
    github.com/cweill/gotests/... \ 
    github.com/josharian/impl@latest"

Description

Additions

  • gomodifytags
  • goplay
  • gotests
  • impl

added the following tools that were newly added to go tools list

Removed

  • gopkgs
    removed it because removed from the list in go tools list

  • go-outlines
    removed it because it had replacedByGopls set to true.

Other

In addition, regarding linting tools, the following ones are not used by default, but they are set as optional attributes by the official documentation, allowing users to choose them. Therefore, in this pull request, we have kept them without removing:

  • golint
  • revive
  • go-clilint

@devshun devshun requested a review from a team as a code owner May 24, 2023 00:27
Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, left some comments!

src/go/install.sh Show resolved Hide resolved
src/go/install.sh Show resolved Hide resolved
src/go/install.sh Show resolved Hide resolved
src/go/install.sh Outdated Show resolved Hide resolved
@devshun
Copy link
Contributor Author

devshun commented May 27, 2023

@samruddhikhandale

Thank you for your review! I have addressed your comments. When you have a moment, could you please check again?

@devshun
Copy link
Contributor Author

devshun commented May 27, 2023

@microsoft-github-policy-service agree

Copy link
Member

@samruddhikhandale samruddhikhandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@samruddhikhandale samruddhikhandale merged commit cfae3b0 into devcontainers:main May 31, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] update go tools
3 participants