Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dotnet: Fix Feature failures on ubuntu:jammy (when installing using apt) #590

Merged
merged 6 commits into from
Jun 29, 2023
Merged

Dotnet: Fix Feature failures on ubuntu:jammy (when installing using apt) #590

merged 6 commits into from
Jun 29, 2023

Conversation

samruddhikhandale
Copy link
Member

@samruddhikhandale samruddhikhandale commented Jun 26, 2023 •
edited
Loading

Closes: #560

Fixes dotnet Feature failures for ubuntu:jammy:

@samruddhikhandale samruddhikhandale requested a review from a team as a code owner June 26, 2023 21:19
@samruddhikhandale samruddhikhandale changed the title Dotnet: Fixes Feature failures on ubuntu:jammy (when installed using apt) Dotnet: Fix Feature failures on ubuntu:jammy (when installed using apt) Jun 26, 2023
@samruddhikhandale
Copy link
Member Author

Failures for debian:12 (bookworm) are expected as there are no upstream .NET releases yet.
See https://learn.microsoft.com/en-us/dotnet/core/install/linux-debian & dotnet/core#8481

@samruddhikhandale samruddhikhandale changed the title Dotnet: Fix Feature failures on ubuntu:jammy (when installed using apt) Dotnet: Fix Feature failures on ubuntu:jammy (when installing using apt) Jun 26, 2023
joshspicer
joshspicer reviewed Jun 27, 2023
View reviewed changes
src/dotnet/install.sh Outdated Show resolved Hide resolved
joshspicer
joshspicer reviewed Jun 27, 2023
View reviewed changes
src/dotnet/install.sh Outdated Show resolved Hide resolved
joshspicer
joshspicer previously approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@joshspicer joshspicer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you have the time, it might be worth quickly updating the dotnet/test.sh script here for bookworm. From a glance it appears like it's installing fine but latest for bookworm is dotnet 8 instead of 7 (and test is validating for 7)

https://github.com/devcontainers/features/actions/runs/5407307268/jobs/9825172418?pr=590#step:4:452

@samruddhikhandale samruddhikhandale merged commit 300814b into main Jun 29, 2023
12 checks passed
@samruddhikhandale samruddhikhandale deleted the samruddhikhandale/dotnet-fix branch June 29, 2023 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshspicer joshspicer joshspicer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dotnet feature fails to install on ubuntu:jammy
2 participants
@samruddhikhandale @joshspicer