Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPP, Typescript-Node] - Ubuntu-24.04 (noble) & 22-bookworm - updated #256

Merged
merged 8 commits into from
May 17, 2024
Merged

[CPP, Typescript-Node] - Ubuntu-24.04 (noble) & 22-bookworm - updated #256

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1d10b56
[CPP, Typescript-Node] - Ubuntu-24.04 (noble) & 22-bookworm - updated
gauravsaini04 May 15, 2024
14aafcc
more changes
gauravsaini04 May 15, 2024
23f2d2a
more changes
gauravsaini04 May 15, 2024
daf139b
misc change
gauravsaini04 May 15, 2024
1bb5b14
fileext change to js
gauravsaini04 May 15, 2024
e822d53
changes for comments ( review comments on PR )
gauravsaini04 May 15, 2024
6a4548e
misc change
gauravsaini04 May 16, 2024
dbe8ee9
changes as mentioned in comment
gauravsaini04 May 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/cpp-mariadb/devcontainer-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "cpp-mariadb",
"version": "2.1.0",
"version": "2.2.0",
"name": "C++ & MariaDB",
"description": "Develop C++ applications on Linux. Includes Debian C++ build tools.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/cpp-mariadb",
Expand All @@ -9,11 +9,12 @@
"options": {
"imageVariant": {
"type": "string",
"description": "Debian / Ubuntu version (use Debian 12, Debian 11, Ubuntu 22.04 on local arm64/Apple Silicon):",
"description": "Debian / Ubuntu version (use Debian 12, Debian 11, Ubuntu 24.04, and Ubuntu 22.04 on local arm64/Apple Silicon):",
"proposals": [
"debian-12",
"debian-11",
"debian-10",
"ubuntu-24.04",
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
"ubuntu-22.04",
"ubuntu-20.04"
],
Expand Down
5 changes: 3 additions & 2 deletions src/cpp/devcontainer-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "cpp",
"version": "2.1.0",
"version": "2.2.0",
"name": "C++",
"description": "Develop C++ applications on Linux. Includes Debian C++ build tools.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/cpp",
Expand All @@ -9,11 +9,12 @@
"options": {
"imageVariant": {
"type": "string",
"description": "Debian / Ubuntu version (use Debian 12, Debian 11, Ubuntu 22.04 on local arm64/Apple Silicon):",
"description": "Debian / Ubuntu version (use Debian 12, Debian 11, Ubuntu 24.04, and Ubuntu 22.04 on local arm64/Apple Silicon):",
"proposals": [
"debian-12",
"debian-11",
"debian-10",
"ubuntu-24.04",
"ubuntu-22.04",
"ubuntu-20.04"
],
Expand Down
6 changes: 4 additions & 2 deletions src/typescript-node/devcontainer-template.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"id": "typescript-node",
"version": "3.1.0",
"version": "3.2.0",
"name": "Node.js & TypeScript",
"description": "Develop Node.js based applications in TypeScript. Includes Node.js, eslint, nvm, yarn, and the TypeScript compiler.",
"documentationURL": "https://github.com/devcontainers/templates/tree/main/src/typescript-node",
Expand All @@ -11,14 +11,16 @@
"type": "string",
"description": "Node.js version (use -bookworm, -bullseye variants on local arm64/Apple Silicon):",
"proposals": [
"22-bookworm",
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
gauravsaini04 marked this conversation as resolved.
Show resolved Hide resolved
"22-bullseye",
"20-bookworm",
"18-bookworm",
"20-bullseye",
"18-bullseye",
"20-buster",
"18-buster"
],
"default": "20-bullseye"
"default": "22-bookworm"
}
},
"platforms": [
Expand Down
24 changes: 0 additions & 24 deletions test/typescript-node/.eslintrc.json
View file
Open in desktop

This file was deleted.

11 changes: 11 additions & 0 deletions test/typescript-node/eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
module.exports={
"rules": {
"no-console": 0,
"eqeqeq":"warn",
"no-cond-assign": 0,
"no-unused-vars": 1,
"no-extra-semi": "warn",
"semi": "warn"
},
ignorePatterns: ["**/node_modules/**"]
};
2 changes: 1 addition & 1 deletion test/typescript-node/test.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ check "node" node --version
sudo rm -f yarn.lock
check "yarn" yarn install
sudo rm -f package-lock.json
check "eslint" eslint --no-eslintrc -c .eslintrc.json src/server.ts
check "eslint" eslint --no-warn-ignored src/server.ts
check "typescript" npm run compile
check "test-project" npm run test
npm config delete prefix
Expand Down
Loading