Skip to content

Commit

Permalink
This should fix the bug where it can't deal with an optimizer running…
Browse files Browse the repository at this point in the history
… for more then 60 hours
  • Loading branch information
devedse committed Jul 28, 2020
1 parent cd9b5ac commit f3b54a5
Show file tree
Hide file tree
Showing 3 changed files with 12 additions and 41 deletions.
19 changes: 10 additions & 9 deletions WebOptimizationProject/Helpers/TemplatesHandler.cs
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using DeveImageOptimizer;
using DeveCoolLib.Conversion;
using DeveImageOptimizer;
using DeveImageOptimizer.State;
using System;
using System.Collections.Generic;
Expand Down Expand Up @@ -46,11 +47,11 @@ public static string GetCommitDescriptionForPullRequest(string clonedRepoPath, s
templateText = templateText.Replace("{FilesOptimizedSuccessfully}", optimizedFileResults.Count(t => t.OptimizationResult == OptimizationResult.Success).ToString());
templateText = templateText.Replace("{FilesAlreadyOptimized}", optimizedFileResults.Count(t => t.OptimizationResult == OptimizationResult.Skipped).ToString());
templateText = templateText.Replace("{FilesFailedOptimization}", optimizedFileResults.Count(t => t.OptimizationResult == OptimizationResult.Failed).ToString());
templateText = templateText.Replace("{TotalBytesBefore}", UomHelper.BytesToString(totalBytesBefore));
templateText = templateText.Replace("{TotalBytesAfter}", UomHelper.BytesToString(totalBytesAfter));
templateText = templateText.Replace("{TotalBytesBefore}", ValuesToStringHelper.BytesToString(totalBytesBefore));
templateText = templateText.Replace("{TotalBytesAfter}", ValuesToStringHelper.BytesToString(totalBytesAfter));
templateText = templateText.Replace("{PercentageRemaining}", $"{percentageRemaining}%");
templateText = templateText.Replace("{TotalBytesSaved}", UomHelper.BytesToString(totalBytesSaved));
templateText = templateText.Replace("{OptimizationDuration}", UomHelper.SecondsToString((long)timeSpan.TotalSeconds));
templateText = templateText.Replace("{TotalBytesSaved}", ValuesToStringHelper.BytesToString(totalBytesSaved));
templateText = templateText.Replace("{OptimizationDuration}", ValuesToStringHelper.SecondsToString((long)timeSpan.TotalSeconds));

var optimizedFilesTable = new StringBuilder();

Expand All @@ -75,10 +76,10 @@ public static string GetCommitDescriptionForPullRequest(string clonedRepoPath, s
fileName = $"[{fileName}]({relativeGitPath})";
}

var originalSize = UomHelper.BytesToString(fileResult.OriginalSize);
var optimizedSize = UomHelper.BytesToString(fileResult.OptimizedSize);
var bytesSaved = UomHelper.BytesToString(fileResult.OriginalSize - fileResult.OptimizedSize);
optimizedFilesTable.AppendLine($"{fileName} | {originalSize} | {optimizedSize} | {bytesSaved} | {UomHelper.SecondsToString((long)fileResult.Duration.TotalSeconds)} | {fileResult.OptimizationResult}");
var originalSize = ValuesToStringHelper.BytesToString(fileResult.OriginalSize);
var optimizedSize = ValuesToStringHelper.BytesToString(fileResult.OptimizedSize);
var bytesSaved = ValuesToStringHelper.BytesToString(fileResult.OriginalSize - fileResult.OptimizedSize);
optimizedFilesTable.AppendLine($"{fileName} | {originalSize} | {optimizedSize} | {bytesSaved} | {ValuesToStringHelper.SecondsToString((long)fileResult.Duration.TotalSeconds)} | {fileResult.OptimizationResult}");
}

templateText = templateText.Replace("{OptimizedFiles}", optimizedFilesTable.ToString());
Expand Down
31 changes: 0 additions & 31 deletions WebOptimizationProject/Helpers/UomHelper.cs

This file was deleted.

3 changes: 2 additions & 1 deletion WebOptimizationProject/WebOptimizationProject.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@

<ItemGroup>
<PackageReference Include="AdysTech.CredentialManager" Version="2.2.0" />
<PackageReference Include="DeveImageOptimizer" Version="1.0.348" />
<PackageReference Include="DeveCoolLib" Version="1.0.40" />
<PackageReference Include="DeveImageOptimizer" Version="1.0.349" />
<PackageReference Include="Newtonsoft.Json" Version="12.0.3" />
<PackageReference Include="Octokit" Version="0.48.0" />
</ItemGroup>
Expand Down

0 comments on commit f3b54a5

Please sign in to comment.