Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Easy] Feature request: make table look prettier #4

Open
DataDrivenEngineer opened this issue Apr 29, 2022 · 4 comments
Open

[Easy] Feature request: make table look prettier #4

DataDrivenEngineer opened this issue Apr 29, 2022 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@DataDrivenEngineer
Copy link
Contributor

Difficulty

Easy

What you need to do

Read description of the issue below and try to fix it.

Hints

  1. Read issue description below carefully and ensure that you understand it.
  2. Begin by exploring the code to understand which parts of code are responsible for table styling. Remember: the more thoroughly you understand the code, the more elegant and lightweight solution you will be able to come up with.

Issue description

Design team came up with a new design for 'My Customers' table - see the mock below. Please update the website so that it looks the same as on the image. See 'Expected behavior' section below for more details.

new-design

Expected behavior

Both table border and background have new color. Color code: lightblue. You can use this code to set the color in stylesheet.

@DataDrivenEngineer DataDrivenEngineer added enhancement New feature or request good first issue Good for newcomers labels Apr 29, 2022
@ronran1
Copy link

ronran1 commented Apr 30, 2022

Hi, I made a quick fix by modifying two lines on styles.css. Here's the result. Could you assign me this so I can open a pull request? Thanks for sharing this issue, it was well-documented.
Screen Shot 2022-04-30 at 12 32 03 PM

Edit: I realize now that one doesn't have to be assigned something to open a pull request. Apologies, it's my first open-source contribution.

@DataDrivenEngineer
Copy link
Contributor Author

DataDrivenEngineer commented Apr 30, 2022 via email

@JeppeHauman
Copy link

Hi, I think i did everything right when cloning and creating a new branch to work on. I created a new pull request for you to look at.

@mtheus96
Copy link

mtheus96 commented Dec 1, 2022

I've solved this and made a pull request.

JunYuHuang added a commit to JunYuHuang/javascript-crm that referenced this issue Apr 9, 2023
clowjs added a commit to clowjs/javascript-crm that referenced this issue Nov 28, 2023
AnneChaiyato pushed a commit to AnneChaiyato/javascript-crm that referenced this issue Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants