Update instructions in ruby-installation.md #482
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Fedora 38, also package perl-FindBin is needed to successfully install rbenv. Also, updating the rbenv example to ruby 2.7.8 Ruby 2.7.8 is the latest and last version of ruby major version 2. Ruby 2 is now end of life.
|
Thanks for the contribution. I have a PR that addresses the outdatedness of Ruby pages: It includes pretty much what you have suggested. I went with Ruby 3.0, as Ruby 2.7 went unsupported by upstream with the update to 2.7.8. Would you mind reviewing that? Also thanks for noticing that perl dependency. |
|
Jarek,
Your change is huge and I cannot review all of the details now.
Can we go step by step and merge smaller parts?
Also, seeing that there are old approved PR's, which nobody merged, I am
not sure if it is worth spending extra effort there.
Mirek Svoboda
…On Mon, 17 Jul 2023 at 14:36, Jarek Prokop ***@***.***> wrote:
Thanks for the contribution. I have a PR that addresses the outdatedness
of Ruby pages:
#478 <#478>
It includes pretty much what you have suggested. I went with Ruby 3.0, as
Ruby 2.7 went unsupported by upstream with the update to 2.7.8.
Would you mind reviewing that? Also thanks for noticing that perl
dependency.
—
Reply to this email directly, view it on GitHub
<#482 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB3RMNEGZXSS3APXJ5DTV6TXQUWVTANCNFSM6AAAAAA2M3ZIXE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I wanted to merge it, but then when retrying fresh rbenv install on a fresh VM, I bumped into the Perl dep and haven't had time to investigate further. Otherwise there is some housekeeping due for the PRs for some time now. |
jackorp
added a commit
that referenced
this pull request
Aug 11, 2023
* Remove JRuby mentions This is not packaged in Fedora for some time now. * Update Ruby section dealing with bundled libraries. This will allow for more complete installations. Delete `tk` related library mention, it is not distributed with Fedora Ruby for some time. * Update Ruby's rbenv installation page * Add required perl-FindBin package to rbenv instructions. Thanks to #482 * IsItFedoraRuby app is not available for some time.
|
Thanks! Closing as #478 includes these changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Fedora 38, also package perl-FindBin is needed to successfully install ruby with rbenv.
Also, updating the rbenv example to ruby 2.7.8 Ruby 2.7.8 is the latest and last version of ruby major version 2. Ruby 2 is now end of life.