Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subsection image for Virtualization inside the Tools section #121

Closed
gridhead opened this issue Sep 8, 2021 · 2 comments · Fixed by #122
Closed

Add subsection image for Virtualization inside the Tools section #121

gridhead opened this issue Sep 8, 2021 · 2 comments · Fixed by #122

Comments

@gridhead
Copy link
Contributor

gridhead commented Sep 8, 2021

I am trying to introduce a new subsection with the PR developer-portal/content#394 but it cannot be merged yet as the subsection does not have a logo.

Noting that the section that I am talking about here was newly introduced by me with this pull request. Here's the log.

podman run -it --rm -p 4000:4000 -v "$PWD:/opt/developerportal/website/content:Z" quay.io/developer-portal/devel
Configuration file: /opt/developerportal/website/_config.yml
            Source: /opt/developerportal/website
       Destination: /opt/developerportal/website/_site
 Incremental build: enabled
      Generating... 
       Git authors: Generating authors...
Traceback (most recent call last):
  File "/opt/developerportal/website/rss.py", line 23, in <module>
    feedparser._HTMLSanitizer.unacceptable_elements_with_end_tag.add('<div>')
AttributeError: module 'feedparser' has no attribute '_HTMLSanitizer'
                    done in 6.125 seconds.
 Auto-regeneration: enabled for '/opt/developerportal/website'
LiveReload address: http://0.0.0.0:35729
    Server address: http://0.0.0.0:4000/
  Server running... press ctrl-c to stop.
[2021-09-08 02:14:07] ERROR `/static/logo/virtualization.png' not found.
[2021-09-08 02:14:14] ERROR `/static/logo/virtualization.png' not found.
[2021-09-08 02:14:22] ERROR `/static/logo/virtualization.png' not found.
@gridhead
Copy link
Contributor Author

gridhead commented Sep 8, 2021

Here are some screenshots.

v02

v01

@jackorp
Copy link
Contributor

jackorp commented Sep 8, 2021

Hmm, this is not a broken container image but a missing logo.

An image is needed, must have an open-source license, format preferably png that will have the path website/static/logo/virtualization.png, named after the subsection, after that the logo should be visible in the virtualization page.

For licenses, Fedora has a list of "good/bad" licenses which could be a good source should you be unsure if some image can be redistributed.

Please reach out if you have any further questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants