Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Virtualization #394

Merged
merged 20 commits into from
Nov 5, 2021
Merged

Virtualization #394

merged 20 commits into from
Nov 5, 2021

Conversation

gridhead
Copy link
Contributor

@gridhead gridhead commented Sep 3, 2021

Added 13 pages of goodness. :)

Fixes #392

Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
@gridhead
Copy link
Contributor Author

gridhead commented Sep 3, 2021

PLEASE DO NOT MERGE YET

The section icon is broken and I do not know how to add one.

01

@gridhead
Copy link
Contributor Author

gridhead commented Sep 7, 2021

Hey @pvalena, could you please see if you can do something about the broken image?

@jackorp
Copy link
Contributor

jackorp commented Sep 7, 2021

Hey @pvalena, could you please see if you can do something about the broken image?

Hi, could you please create an issue at developer-portal/website describing the command you ran and the output?

I ran

$ docker run -it --rm -p4000:4000 -v "$PWD:/opt/developerportal/website/content:Z" quay.io/developer-portal/devel

successfully on this PR.

Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
@gridhead
Copy link
Contributor Author

gridhead commented Sep 8, 2021

Hi @jackorp,

Noting that the section that I am talking about here was newly introduced by me with this pull request. Here's the log.

podman run -it --rm -p 4000:4000 -v "$PWD:/opt/developerportal/website/content:Z" quay.io/developer-portal/devel
Configuration file: /opt/developerportal/website/_config.yml
            Source: /opt/developerportal/website
       Destination: /opt/developerportal/website/_site
 Incremental build: enabled
      Generating... 
       Git authors: Generating authors...
Traceback (most recent call last):
  File "/opt/developerportal/website/rss.py", line 23, in <module>
    feedparser._HTMLSanitizer.unacceptable_elements_with_end_tag.add('<div>')
AttributeError: module 'feedparser' has no attribute '_HTMLSanitizer'
                    done in 6.125 seconds.
 Auto-regeneration: enabled for '/opt/developerportal/website'
LiveReload address: http://0.0.0.0:35729
    Server address: http://0.0.0.0:4000/
  Server running... press ctrl-c to stop.
[2021-09-08 02:14:07] ERROR `/static/logo/virtualization.png' not found.
[2021-09-08 02:14:14] ERROR `/static/logo/virtualization.png' not found.
[2021-09-08 02:14:22] ERROR `/static/logo/virtualization.png' not found.

Here's a link to the ticket that I created there developer-portal/website#121.

@pvalena
Copy link
Contributor

pvalena commented Sep 8, 2021

What confuses me that virtualization is a general term, or a category, rather than a specific tool. Ideas?

CC: @hhorak

@gridhead
Copy link
Contributor Author

@pvalena, I do seem to have covered at least three tools from the virtualization but maybe we should have a major section to itself.

@pvalena
Copy link
Contributor

pvalena commented Sep 16, 2021

Actually, looking once more at it, it looks like it fits into tools, as it quite describe the low-level tools one might use, when working with virtualization.

Thanks once more!

Copy link
Contributor

@pvalena pvalena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for a such a broad PR!

I've written some suggestions, hopefully it's all straightforward.

I'd rearrange it a bit, and also change mainly:

  • the code-block notations to command with $ and have the output follow right after the command in the same block
  • trim some of the example output (the non-essential parts)
  • describe what's being done, what's the aim of the command / sub-page, or expected result
  • use sub-headers ## and sub-sub-headers ### instead of numbering where suitable.

Let me know if you have any questions.

tools/virtualization/about.md Outdated Show resolved Hide resolved
tools/virtualization/about.md Outdated Show resolved Hide resolved
tools/virtualization/about.md Outdated Show resolved Hide resolved
4. Open up `Settings` inside the VM and head over to the `About` section. Information about the `Graphics` can be seen here.
5. Open up `Terminal` inside the VM and execute the `lspci` commands in regards with the current VGA controller to find more information on it.

We will test out each VGA provider one-by-one and list the information for each now.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also describe the outcomes / implications for a regular user? IOW what's the aim / expected result of this testing / comparison?

order: 11
---

# Playing around with various VGA providers
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have some more concise title like e.g.:

Suggested change
# Playing around with various VGA providers
# Setting up various VGA providers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reason why I would suggest it to stay the same is because most VGA providers are very experimental in nature and people would not want to use them in a critical environment. They would still want to play around with them as these are actively developed and might be stable someday. What do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe that could be mentioned stand alone / explicitly - maybe with Experimental in the sub-title? (Instead of being "in between the lines", as many non-native speakers won't capture that information.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about "Experimenting with various VGA providers" as a title?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great!

@gridhead
Copy link
Contributor Author

@pvalena,

Many thanks for the comprehensive review. I will line up the changes in a while and tag you back in when I am done making the suggested changes.

Addressed #394 (comment) and #394 (comment)

Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Addressed #394 (comment)

Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Addressed #394 (comment)

Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Addressed #394 (comment), #394 (comment) and #394 (comment)

Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Addressed #394 (comment)

Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Addressed #394 (comment) and #394 (comment)

Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
@gridhead
Copy link
Contributor Author

gridhead commented Oct 8, 2021

@pvalena,

I made the requested changes. Do take a look. :)

@jackorp
Copy link
Contributor

jackorp commented Oct 30, 2021

LGTM. Please also provide the source of the logo and license of the logo in the PR website#122, We can then merge both.

Thanks!

@gridhead
Copy link
Contributor Author

gridhead commented Nov 1, 2021

@jackorp, developer-portal/website#122 is now merged.

Please see if this PR can be merged now.

@jackorp
Copy link
Contributor

jackorp commented Nov 5, 2021

LGTM, let's merge it.

@jackorp jackorp merged commit 4ae5976 into developer-portal:master Nov 5, 2021
@pvalena
Copy link
Contributor

pvalena commented Nov 5, 2021

@t0xic0der Thanks for the good work!

Let's polish this in staging:
- https://developer.stg.fedoraproject.org/tools/virtualization/about.html

@gridhead
Copy link
Contributor Author

gridhead commented Nov 6, 2021

Sure @pvalena. I am proofreading the contents right now. What else needs to be added?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Guide about QEMU, KVM and Libvirt
3 participants