-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Virtualization #394
Virtualization #394
Conversation
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Hey @pvalena, could you please see if you can do something about the broken image? |
Hi, could you please create an issue at developer-portal/website describing the command you ran and the output? I ran
successfully on this PR. |
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Hi @jackorp, Noting that the section that I am talking about here was newly introduced by me with this pull request. Here's the log.
Here's a link to the ticket that I created there developer-portal/website#121. |
What confuses me that CC: @hhorak |
@pvalena, I do seem to have covered at least three tools from the virtualization but maybe we should have a major section to itself. |
Actually, looking once more at it, it looks like it fits into Thanks once more! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for a such a broad PR!
I've written some suggestions, hopefully it's all straightforward.
I'd rearrange it a bit, and also change mainly:
- the code-block notations to command with
$
and have the output follow right after the command in the same block - trim some of the example output (the non-essential parts)
- describe what's being done, what's the aim of the command / sub-page, or expected result
- use sub-headers
##
and sub-sub-headers###
instead of numbering where suitable.
Let me know if you have any questions.
tools/virtualization/installing-libvirt-and-virt-install-on-fedora-linux.md
Outdated
Show resolved
Hide resolved
4. Open up `Settings` inside the VM and head over to the `About` section. Information about the `Graphics` can be seen here. | ||
5. Open up `Terminal` inside the VM and execute the `lspci` commands in regards with the current VGA controller to find more information on it. | ||
|
||
We will test out each VGA provider one-by-one and list the information for each now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also describe the outcomes / implications for a regular user? IOW what's the aim / expected result of this testing / comparison?
order: 11 | ||
--- | ||
|
||
# Playing around with various VGA providers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have some more concise title like e.g.:
# Playing around with various VGA providers | |
# Setting up various VGA providers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason why I would suggest it to stay the same is because most VGA providers are very experimental in nature and people would not want to use them in a critical environment. They would still want to play around with them as these are actively developed and might be stable someday. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe that could be mentioned stand alone / explicitly - maybe with Experimental in the sub-title? (Instead of being "in between the lines", as many non-native speakers won't capture that information.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about "Experimenting with various VGA providers" as a title?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great!
tools/virtualization/playing-around-with-various-vga-providers.md
Outdated
Show resolved
Hide resolved
tools/virtualization/setting-up-fedora-workstation-vm-on-qemu-using-uefi.md
Show resolved
Hide resolved
Many thanks for the comprehensive review. I will line up the changes in a while and tag you back in when I am done making the suggested changes. |
Addressed #394 (comment) and #394 (comment) Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Addressed #394 (comment) Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Addressed #394 (comment) Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Addressed #394 (comment), #394 (comment) and #394 (comment) Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Addressed #394 (comment) Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
Addressed #394 (comment) and #394 (comment) Signed-off-by: Akashdeep Dhar <akashdeep.dhar@gmail.com>
I made the requested changes. Do take a look. :) |
LGTM. Please also provide the source of the logo and license of the logo in the PR website#122, We can then merge both. Thanks! |
@jackorp, developer-portal/website#122 is now merged. Please see if this PR can be merged now. |
LGTM, let's merge it. |
@t0xic0der Thanks for the good work! Let's polish this in staging: |
Sure @pvalena. I am proofreading the contents right now. What else needs to be added? |
Added 13 pages of goodness. :)
Fixes #392