-
Notifications
You must be signed in to change notification settings - Fork 36
Attempt to fix the deployment workflow #150
Conversation
馃殌 Deployed on https://deploy-preview-150--developersindia.netlify.app |
As I thought (and as I discussed over call) the the secret tokens are correct but the Action's environment couldn't access them for whatever reason (see the description of #149 for a possible explanation). This PR makes it work somehow but further testing & experimentation is required to see if workflows triggered from forked pull requests can access the tokens or not. Regardless, this PR kinda fixed the concern we had with the CI/CD pipeline(?). At least now, it not only deploys to Netlify but also comments on the PR with a preview URL.
|
@Bhupesh-V can we merge after you review it so that we can test pull requests from forked repositories triggering the workflows have access to the secret tokens as well? Having this PR merged to @charan1973 @uragirii can you guys fork & send some trivial PRs to help us test the workflow works as we expect it to? But wait for us to merge it to |
@Jarmos-san great work! The deployment url works correctly imo. But the problem may arise when forking and creating a PR (most common use-case for this repo)
Sure, will do. afaik i would get an email once this PR is merged and then I would create a trivial PR (yay! for the first contribution) |
Leaving this one comment & this workflow permissions I stumbled upon while trying to setup a work-related project as well. |
Pull Request Template
Description
The PR contains an updated workflow file which "should fix" the current CI/CD pipeline.
Fixes #149 (if everything works as expected though)
Changes Include
Checklist