Skip to content
This repository has been archived by the owner on Feb 8, 2023. It is now read-only.

Attempt to fix the deployment workflow #150

Merged
merged 4 commits into from
Apr 16, 2022
Merged

Attempt to fix the deployment workflow #150

merged 4 commits into from
Apr 16, 2022

Conversation

Jarmos-san
Copy link
Member

Pull Request Template

Description

The PR contains an updated workflow file which "should fix" the current CI/CD pipeline.

Fixes #149 (if everything works as expected though)

Changes Include

  • Bug fix 馃悰 (non-breaking change which fixes an issue)
  • Refactor 鈿掞笍 (code change that neither fixes a bug nor adds a feature)
  • Tooling 鈿欙笍 (Changes to the build process or auxiliary tools and libraries such as documentation generation)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

@Jarmos-san Jarmos-san added the bug Something isn't working label Mar 27, 2022
@Jarmos-san Jarmos-san added this to the Current milestone Mar 27, 2022
@Jarmos-san Jarmos-san self-assigned this Mar 27, 2022
@Jarmos-san Jarmos-san added this to In progress in Housekeeping Status via automation Mar 27, 2022
@github-actions
Copy link

github-actions bot commented Mar 27, 2022

@github-actions github-actions bot temporarily deployed to Netlify Deployments March 27, 2022 20:13 Inactive
@Jarmos-san
Copy link
Member Author

Jarmos-san commented Mar 27, 2022

As I thought (and as I discussed over call) the the secret tokens are correct but the Action's environment couldn't access them for whatever reason (see the description of #149 for a possible explanation).

This PR makes it work somehow but further testing & experimentation is required to see if workflows triggered from forked pull requests can access the tokens or not. Regardless, this PR kinda fixed the concern we had with the CI/CD pipeline(?). At least now, it not only deploys to Netlify but also comments on the PR with a preview URL.

Do note, the preview URL shows a 404 page which I believe is because of a broken Next.js build (this should be fixed if #144 is merged to the master branch.

@Jarmos-san Jarmos-san changed the title chore: attempt to fix the deployment workflow Attempt to fix the deployment workflow Mar 27, 2022
@Jarmos-san
Copy link
Member Author

@Bhupesh-V can we merge after you review it so that we can test pull requests from forked repositories triggering the workflows have access to the secret tokens as well?

Having this PR merged to master will make it so much more easier to check what changes did people introduce to the website (the preview URL will help us on that regards, see comment above).

@charan1973 @uragirii can you guys fork & send some trivial PRs to help us test the workflow works as we expect it to? But wait for us to merge it to master branch first.

@github-actions github-actions bot temporarily deployed to Netlify Deployments March 28, 2022 11:30 Inactive
@uragirii
Copy link

@Jarmos-san great work! The deployment url works correctly imo. But the problem may arise when forking and creating a PR (most common use-case for this repo)

@charan1973 @uragirii can you guys fork & send some trivial PRs to help us test the workflow works as we expect it to? But wait for us to merge it to master branch first.

Sure, will do. afaik i would get an email once this PR is merged and then I would create a trivial PR (yay! for the first contribution)

@Jarmos-san
Copy link
Member Author

Jarmos-san commented Mar 29, 2022

Leaving this one comment & this workflow permissions I stumbled upon while trying to setup a work-related project as well.

@Jarmos-san Jarmos-san merged commit ac38929 into master Apr 16, 2022
Housekeeping Status automation moved this from In progress to Done Apr 16, 2022
@Jarmos-san Jarmos-san deleted the issue-149 branch April 16, 2022 20:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

[BUG]: Fix & make the current CI/CD pipeline more robust
2 participants