Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Aspect ratio preview odd behavior #1

Open
dlford opened this issue Sep 11, 2022 · 6 comments
Open

[Bug]: Aspect ratio preview odd behavior #1

dlford opened this issue Sep 11, 2022 · 6 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest This is a valid Hacktoberfest issue help wanted Anyone can pick this up and start working on it

Comments

@dlford
Copy link
Member

dlford commented Sep 11, 2022 •
edited
Loading

Contact Details

No response

What happened?

Choosing an extremely low width or height causes the preview window to show an inaccurate representation of that aspect ratio

What should have happened?

Aspect ratio preview should show an accurate representation of the selected ratio

What browsers are you seeing the problem on?

Firefox

Version

104.0.2

Relevant Code

https://github.com/developertools-tech/developertools.tech/blob/main/components/aspectRatio/Preview.tsx#L15
@dlford dlford added bug Something isn't working tool: aspect ratio triage New issue that needs to be assessed help wanted Anyone can pick this up and start working on it good first issue Good for newcomers and removed triage New issue that needs to be assessed tool: aspect ratio labels Sep 11, 2022
@dlford dlford added the hacktoberfest This is a valid Hacktoberfest issue label Oct 3, 2022
@nobalpha
Copy link

nobalpha commented Oct 8, 2022

Hey @dlford , can I try to resolve it?

@dlford dlford removed the help wanted Anyone can pick this up and start working on it label Oct 8, 2022
@dlford
Copy link
Member Author

dlford commented Oct 8, 2022

@nobalpha All yours, thanks!

dlford pushed a commit that referenced this issue Oct 9, 2022
@AnkitaMalik22
Merge pull request #1 from dlford/text-diff
005f79b 
Text diff
@dlford
Copy link
Member Author

dlford commented Oct 19, 2022

@nobalpha are you still wanting to work on this?

@nobalpha
Copy link

@dlford So sorry to reply lately... Can you please accord a little bit more time?

@dlford
Copy link
Member Author

dlford commented Oct 20, 2022

@nobalpha no problem, just making sure you still wanted to do it!

@dlford dlford removed the hacktoberfest This is a valid Hacktoberfest issue label Nov 6, 2022
@dlford
Copy link
Member Author

dlford commented Dec 18, 2022

Hey @nobalpha, are you still working on this?

@dlford dlford added the help wanted Anyone can pick this up and start working on it label Jan 12, 2023
@dlford dlford added the hacktoberfest This is a valid Hacktoberfest issue label Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest This is a valid Hacktoberfest issue help wanted Anyone can pick this up and start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dlford @nobalpha