Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing text in CodeSandbox sample #49

Closed
lbittner-pdftron opened this issue Dec 21, 2018 · 2 comments
Closed

Missing text in CodeSandbox sample #49

lbittner-pdftron opened this issue Dec 21, 2018 · 2 comments
Labels
documentation question Further information is requested

Comments

@lbittner-pdftron
Copy link

lbittner-pdftron commented Dec 21, 2018

Hello!

I was playing around with your CodeSandbox sample and noticed some missing text.

Here's my fork of the sample: https://codesandbox.io/s/7jx016lwo6

Notice that the name prop passed to header has some static text appended to the beginning.

<${Header} name="THIS SHOULD BE RENDERED (${page})" />

When the header is rendered, the static text is missing and just All List is rendered.

I might be missing something here but I would expect the header to say THIS SHOULD BE RENDERED (All) List instead of just All List.

Thanks!

EDIT: This is reproducible in your CodeSandbox demo as well - I just made a few changes to make it more clear.

@developit
Copy link
Owner

Looks like we're missing a test for this. Technically the correct syntax would be:

html`<${Header} name=${'THIS SHOULD BE RENDERED (' + page + ')'} />`

@developit
Copy link
Owner

This is fixed in HTM 2.2 (codesandbox auto-updated!).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants