Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript : should use rollup-plugin-typescript2 instead of rollup-plugin-typescript #63

Closed
freeman opened this issue Jan 25, 2018 · 4 comments · Fixed by #71
Closed

Comments

@freeman
Copy link
Contributor

freeman commented Jan 25, 2018

Great to see the progress on typescript integration !

However the current version uses rollup-plugin-typescript which uses Typescript 1.8 which is very old.

I think switching to rollup-plugin-typescript2 should bring better defaults. In addition I think this should help with #58

@developit
Copy link
Owner

Good catch!

@freeman
Copy link
Contributor Author

freeman commented Jan 25, 2018

Happy to do a PR soon if nobody is on it.

@developit
Copy link
Owner

developit commented Jan 26, 2018

@tymondesigns submitted a PR to move to TS2. Do we think it's also necessary to move to rollup-plugin-typescript2?

@freeman
Copy link
Contributor Author

freeman commented Jan 28, 2018

For my use case, seems the rollup-plugin-typescript2 would be a better fit because it supports generating .d.ts files from the typescript sources which I consider an essential feature.

I have tested it and it seems to work perfectly... I'll send a PR and we'll discuss around it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants