Use publicPath for SW & Manifest paths (#323)

* Make template.html use publicPath for manifest * Adds __webpack_public_path__ to registration of sw.js * Disable eslint for __webpack_public_path__
preactjs · Oct 11, 2017 · 52e9843 · 52e9843
1 parent 0057199
commit 52e9843
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/lib/entry.js b/src/lib/entry.js
@@ -5,7 +5,8 @@ if (process.env.NODE_ENV==='development') {
 	require('preact/devtools');
 }
 else if (process.env.ADD_SW && 'serviceWorker' in navigator && location.protocol === 'https:') {
-	navigator.serviceWorker.register('/sw.js');
+	// eslint-disable-next-line no-undef
+	navigator.serviceWorker.register(__webpack_public_path__ + 'sw.js');
 }
 
 

diff --git a/src/resources/template.html b/src/resources/template.html
@@ -6,7 +6,7 @@
 		<meta name="viewport" content="width=device-width,initial-scale=1">
 		<meta name="mobile-web-app-capable" content="yes">
 		<meta name="apple-mobile-web-app-capable" content="yes">
-		<link rel="manifest" href="/manifest.json">
+		<link rel="manifest" href="<%= htmlWebpackPlugin.files.publicPath %>manifest.json">
 		<% if (htmlWebpackPlugin.options.manifest.theme_color) { %>
 			<meta name="theme-color" content="<%= htmlWebpackPlugin.options.manifest.theme_color %>">
 		<% } %>