Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eject option #199

Closed
knight-bubble opened this issue Jul 7, 2017 · 9 comments
Closed

Eject option #199

knight-bubble opened this issue Jul 7, 2017 · 9 comments

Comments

@knight-bubble
Copy link
Contributor

Are there any plans of adding "eject" option, similar to https://github.com/facebookincubator/create-react-app#converting-to-a-custom-setup?

@prateekbh
Copy link
Member

Is there an ongoing effort for this? else I am planning to take this up and discuss the approaches we can take for this.

@developit
Copy link
Member

I'm not really sure we need eject, since it's possible to customize configuration already. What is the value we get out of providing eject?

@lukeed
Copy link
Member

lukeed commented Jul 10, 2017

I agree ^^ CRA came with eject because it started off with a closed door -- you either liked what you got, or you didn't.

@prateekbh
Copy link
Member

Not sure, I just felt that eject would give user land an option to do anything if they're stuck at any corner case. I know the work for keeping cli flexible is super awesome, but I am the believer that one solution might never fit all. This is when eject makes cli as a boilerplate code.

But yes I do not have a solid use case for now, and may be we can keep this as a P2/P3 for sometime later

@developit
Copy link
Member

Yup. I think the main blocker here is that we have nicely structured the CLI instead of keeping it as a single monolithic webpack.config.js, which means that in order to produce a standalone webpack config we'd have to move back to writing things as a big standalone webpack config (or do crazy codegen magic).

@prateekbh
Copy link
Member

oh yeah, I guess we can park this for now, until someone comes up with a solid use case

@lili21
Copy link

lili21 commented Aug 3, 2017

what's about the project which use something like Docker for building and deploying ?
without eject, I have to install preact-cli every time before building.

@thangngoc89
Copy link
Collaborator

@lili21 you can actually include preact-cli as a devDep to avoid that

@lili21
Copy link

lili21 commented Aug 3, 2017

I know I can do that. It just doesn't feel right. and It still installed preact-cli every time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants