Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion: blocking scroll #5

Open
tomasdev opened this issue Nov 30, 2017 · 1 comment
Open

Suggestion: blocking scroll #5

tomasdev opened this issue Nov 30, 2017 · 1 comment

Comments

@tomasdev
Copy link

Inspired by the use case of blocking scroll (also reactjs/react-modal#60)

Should we consider adding events into Preact Portal or make it add a class to the into? events such as onMount, onUnmount (to their respective preact methods,) or a preact-portal__shown class...

I'm just asking, I'm creating my own component that extends PreactPortal to achieve this. Wondering if it's a valid use case.
@developit
Copy link
Owner

developit commented Jan 15, 2018 •
edited

Not likely a feature we'd build into Portal, but into a modal lib that uses it. Portal is used for more than modals - I use it to render meta tags in <head>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@developit @tomasdev