Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shouldComponentUpdate() Never called on State change. #668

Closed
zanderisrael opened this issue Apr 24, 2017 · 4 comments
Closed

shouldComponentUpdate() Never called on State change. #668

zanderisrael opened this issue Apr 24, 2017 · 4 comments
Labels
feedback needed question

Comments

@zanderisrael
Copy link

zanderisrael commented Apr 24, 2017 •
edited

For some reason, shouldComponentUpdate() is never called in the childeren components on parent state change...

Using: https://github.com/developit/preact-boilerplate as base.

Updated to latest preact release 8.1.0.

Please guide me to what information can help identify the problem.
@developit
Copy link
Member

Are you able to provide a reproduction of the issue? There are quite a few things that could cause this to happen.

@zanderisrael
Copy link
Author

@developit Added you to the project bitbucket, you have read access.

@zanderisrael
Copy link
Author

Update

A jquery lib I used F* things up, sorry for the false alarm.

@developit
Copy link
Member

developit commented Apr 26, 2017 •
edited

tee hee :D
I wondered when I saw that access, didn't make the connection.
Guess we can close this out - thanks for the update! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feedback needed question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@developit @zanderisrael