Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation problem with ts 2.4.0 #735

Closed
valotas opened this issue Jun 22, 2017 · 7 comments
Closed

Compilation problem with ts 2.4.0 #735

valotas opened this issue Jun 22, 2017 · 7 comments

Comments

@valotas
Copy link
Contributor

valotas commented Jun 22, 2017

Trying to compile a project with preact as a dependency and get the following error:

node_modules/preact/dist/preact.d.ts(48,17): error TS2559: Type 'Component<PropsType, StateType>' has no properties in common with type 'ComponentLifecycle<PropsType, StateType>'.

This only happens with ts 2.4.0, 2.3.x works file
@valotas
Copy link
Contributor Author

valotas commented Jun 22, 2017

It looks like it has to do with the introduction of Weak types

ComponentLifecycle should have at least one overlapping property with Component

@marvinhagemeister
Copy link
Member

marvinhagemeister commented Jun 22, 2017 •
edited

This is likely already fixed by #730 (merged yesterday)

@developit
Copy link
Member

Yup, that fix will go out in 8.2.

@valotas
Copy link
Contributor Author

valotas commented Jun 24, 2017

Feel free to close this then :)

@sxcooler
Copy link

sxcooler commented Jul 6, 2017

there's a workaround: fix your typescript version to 2.3.4 until Preact 8.2 published.

@idchlife
Copy link

idchlife commented Jul 9, 2017

Waiting for this one too.

mikehenrty added a commit to common-voice/common-voice that referenced this issue Jul 12, 2017
@mikehenrty
update typescript to fix preact typescript compilation bug preactjs/p…
21a31cb 
…react#735
@adrianabreu adrianabreu mentioned this issue Aug 2, 2017
Closed
@dmylian dmylian mentioned this issue Aug 6, 2017
Closed
@AnWeber AnWeber mentioned this issue Aug 21, 2017
Closed
@2advancesolutions
Copy link

getting error still

@snyk-bot snyk-bot mentioned this issue Feb 12, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@valotas @developit @marvinhagemeister @sxcooler @idchlife @2advancesolutions