Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: ward off evil s #1465

Merged
merged 6 commits into from Apr 22, 2019
Merged

refactor: ward off evil s #1465

merged 6 commits into from Apr 22, 2019

Conversation

mochiya98
Copy link
Contributor

booyah!! ✨
fixes #1461

@coveralls
Copy link

coveralls commented Mar 27, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling d0e32f2 on mochiya98:m98-refactor-e into 8c48a8f on developit:master.

JoviDeCroock
JoviDeCroock reviewed Mar 27, 2019
View reviewed changes
src/diff/index.js Outdated Show resolved Hide resolved
@mochiya98
Copy link
Contributor Author

Thank you for the review, I will reconsider. 🚀

@mochiya98 mochiya98 closed this Mar 27, 2019
@developit
Copy link
Member

@mochiya98 this looks promising! Should be able to swap out the setState() call for just setting .state=.

@mochiya98 mochiya98 reopened this Mar 27, 2019
@mochiya98
Copy link
Contributor Author

mochiya98 commented Mar 27, 2019 •
edited

I fixed the mistake.
@developit thanks! I'm using setState() to process _nextState.

@developit developit mentioned this pull request Mar 27, 2019
Closed
@mochiya98
Copy link
Contributor Author

Any updates on this?

JoviDeCroock
JoviDeCroock approved these changes Apr 4, 2019
View reviewed changes
Copy link
Member

@JoviDeCroock JoviDeCroock left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for working on this @mochiya98. I'm going to wait for another maintainer to voice an opinion but great work already 💯

@mochiya98
Copy link
Contributor Author

Is there any problem? I can help if you need.

marvinhagemeister
marvinhagemeister approved these changes Apr 22, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 🎉 This PR even removes 11 B from our gzipped size. This is presumably because _nextState is compressed better due to more occurrences 💯

Sorry that it took this long to get merged.

@marvinhagemeister marvinhagemeister merged commit 9edba30 into preactjs:master Apr 22, 2019
@mochiya98
Copy link
Contributor Author

Great work, thanks for all reviewers! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@JoviDeCroock JoviDeCroock JoviDeCroock approved these changes

@developit developit Awaiting requested review from developit

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[10.0.0-alpha.2] - setState() doesn't apply state when called within componentWillMount
5 participants
@mochiya98 @coveralls @developit @marvinhagemeister @JoviDeCroock