Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(feat) - debug render #1487

Merged
merged 10 commits into from Mar 31, 2019
Merged

(feat) - debug render #1487

merged 10 commits into from Mar 31, 2019

Conversation

JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Mar 31, 2019 •
edited

I'm personally quite conflicted at this point... It solves a LOT of developer experience bugs but the 27 added bytes are a lot. We could probably get this down to 15-20 by golfing with it a bit but still...

However it does provide a fallback to several bug reports we're getting.

Example: #1485

ADDS: 27B 24B 11B

@JoviDeCroock JoviDeCroock marked this pull request as ready for review March 31, 2019 10:23
@coveralls
Copy link

coveralls commented Mar 31, 2019 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling 760d67a on chore/debugRender into e5e6ce1 on master.

marvinhagemeister
marvinhagemeister reviewed Mar 31, 2019
View reviewed changes
src/render.js Outdated Show resolved Hide resolved
@marvinhagemeister
Copy link
Member

With the suggestions we can bring it down to just +11 B 👍

@JoviDeCroock JoviDeCroock mentioned this pull request Mar 31, 2019
Closed
marvinhagemeister
marvinhagemeister approved these changes Mar 31, 2019
View reviewed changes
Copy link
Member

@marvinhagemeister marvinhagemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really loving it! One last nit with the error message and I think then it's ready to go in 👍 Really excited about this and I hope it will reduce the amount of questions in slack 💯

@marvinhagemeister marvinhagemeister merged commit 83001fd into master Mar 31, 2019
@marvinhagemeister marvinhagemeister deleted the chore/debugRender branch March 31, 2019 12:30
@marvinhagemeister
Copy link
Member

This is so dope 👍 🎉

@ForsakenHarmony
Copy link
Member

Seems like this is missing the typescript definition?

@JoviDeCroock
Copy link
Member Author

@ForsakenHarmony, do you mean for options?

@ForsakenHarmony
Copy link
Member

yup

@JoviDeCroock
Copy link
Member Author

Thanks for the heads up, fixed it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marvinhagemeister marvinhagemeister marvinhagemeister approved these changes

@developit developit Awaiting requested review from developit

@andrewiggins andrewiggins Awaiting requested review from andrewiggins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JoviDeCroock @coveralls @marvinhagemeister @ForsakenHarmony