Code golf diffChildren size down by 33 B ⛳️ #1580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jviide
changed the title
JoviDeCroock
approved these changes
Apr 26, 2019
developit
reviewed
Apr 26, 2019
| let oldChildren = oldParentVNode!=null && oldParentVNode!=EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR; | ||
| // This is a compression of oldParentVNode!=null && oldParentVNode != EMPTY_OBJ && oldParentVNode._children || EMPTY_ARR | ||
| // as EMPTY_OBJ._children should be `undefined`. | ||
| let oldChildren = oldParentVNode!=null && oldParentVNode._children || EMPTY_ARR; |
There was a problem hiding this comment.
This seems safe to me. My guess is the original checks were a combination of before + after oldParentVNode became reliably a (vnode | null).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request reduces the gzipped code size by 33 bytes by progressively refactoring
diffChildren. The commits are roughly in an increasing order of weirdness, so just some of them can be cherry-picked if needed.breakstatements (-7 B)pandindex, with hopefully sufficient comments explaining the logic (-13 B)EMPTY_OBJ._childrenisundefined(-4 B)These changes conflict a bit with @andrewiggins's #1578, sorry about that.