Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't work in firefox #6

Closed
jcubic opened this issue Jan 21, 2017 · 7 comments · Fixed by #8
Closed

Don't work in firefox #6

jcubic opened this issue Jan 21, 2017 · 7 comments · Fixed by #8

Comments

@jcubic
Copy link

jcubic commented Jan 21, 2017

It don't work in Firefox, the event is not fired when there is visibility:hidden. If you remove it it's fired.

@NekR
Copy link
Collaborator

NekR commented Jan 21, 2017

Yeah, it's known thing. More discussion here: #5

@developit I think that had to be already merged..

@NekR
Copy link
Collaborator

NekR commented Jan 21, 2017

I mean, with correct fix for Firefox, of course

@developit
Copy link
Owner

Is it good to merge?

@jcubic
Copy link
Author

jcubic commented Jan 21, 2017

it still will not work in Firefox if visibility:hidden will not be removed.

@developit
Copy link
Owner

developit commented Jan 22, 2017

Yup, just meant there was already an open PR for discussing the specific CSS properties to set. IMO it should be:

position:absolute;top:-100%;width:100%;height:100%;margin:1px 0 0;border:0;opacity:0;pointer-events:none;

I have use that setup in other projects with good success across browsers. It can result in an invisible unclickable 1px bar atop resize-observed elements in IE9 though. For me that was okay. @NekR suggested some JavaScript to work around that by setting visibility:hidden only for IE11 and prior.

@jcubic
Copy link
Author

jcubic commented Jan 22, 2017

I've seen the #5 PR, it don't remove visibility hidden only left:0;top:-100%; opacity:0;

@developit
Copy link
Owner

Yup, that's why it hasn't been merged yet :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants