Separate bootstrapper from DB #90
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way the pgstac database is defined is the following :
In its initial state, this repository was doing (1) and (2) within the same construct, while defining (2) separately. In this PR, I combined the definitions because of JSII problems (see the PR for details).
However, this is not a good set up for users who want to separate their 'stateful' (DB, VPC) and 'stateless' (all lambdas, including bootstrapper) components in different stacks.
The main reason someone wants to keep these things separate is that deploying an RDS instance takes ages. When it's deployed with the bootstrapper lambda (i.e, as part of the same construct), and the bootstrapper lambda fails for some reasons, Cloudformation is going to start a ROLLBACK, and try to delete the RDS instance. This significantly slows down development.
Right now it's impossible to keep the bootstrapper and the RDS instance in separate stacks because the bootstrapper lambda deployment is hard coded within the database construct deployment.
This PR aims at separating the boostrapper lambda creation (and trigger) and the DB creation.