allow None bboxes #119
Merged
allow None bboxes #119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@eseglem could you have a look at this 🙏 |
|
This does look like it addresses the current issue. I had been working on improving bbox validation a bit ago and had pretty much done the same thing in my local branch. I guess I didn't realize it was a bug in the main branch though. Oops. I am going to see about ironing out what I have, but don't see any issue with merging this to make a v0.6.1 for the time being. And I told it to re-run the tests, but apparently the 3.11 one went missing? Can't figure out what's up with that. |
vincentsarago
approved these changes
May 11, 2023
|
thanks @bmschmidt and @eseglem 🙏 I've merged this to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for issues described in #118