Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top level export #34

Merged
merged 7 commits into from
May 21, 2021
Merged

Top level export #34

merged 7 commits into from
May 21, 2021

Conversation

vincentsarago
Copy link
Member

@vincentsarago vincentsarago commented May 21, 2021

closes #25
closes #17

@vincentsarago vincentsarago requested a review from drewbo May 21, 2021 19:47
@codecov-commenter
Copy link

codecov-commenter commented May 21, 2021

Codecov Report

Merging #34 (70748b8) into master (c1e7393) will increase coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   95.87%   95.95%   +0.08%     
==========================================
  Files           4        4              
  Lines          97       99       +2     
==========================================
+ Hits           93       95       +2     
  Misses          4        4              
Flag Coverage Δ
unittests 95.95% <100.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geojson_pydantic/__init__.py 100.00% <100.00%> (ø)
geojson_pydantic/geometries.py 95.23% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1e7393...70748b8. Read the comment docs.

"coordinates": [13.38272, 52.46385],
},
"properties": {
"name": "jeff",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated

MyPointFeatureModel = Feature[Point, MyProps]

>>> MyPointFeatureModel(**geojson_feature)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should also show an example of validation working, not just two examples where validation fails.

vincentsarago and others added 4 commits May 21, 2021 16:58
Co-authored-by: Kyle Barron <kylebarron2@gmail.com>
Co-authored-by: Kyle Barron <kylebarron2@gmail.com>
Co-authored-by: Kyle Barron <kylebarron2@gmail.com>
@vincentsarago vincentsarago merged commit 28a2e0f into master May 21, 2021
@vincentsarago vincentsarago deleted the TopLevelExport branch May 21, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add top level exports add more docs!
3 participants