Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve test coverage, fix a bug #45

Merged
merged 1 commit into from
Feb 21, 2022

Conversation

geospatial-jeff
Copy link
Contributor

@geospatial-jeff geospatial-jeff commented Feb 20, 2022

What I am changing

The main goal of this PR was to improve test coverage. Two cases were not covered:

  • Calling parse_geometry_obj on an object with no type member.
  • Creating a geometry from an object implementing the __geo_interface__ protocol.

Testing the first case revealed a bug that is also fixed in this PR.

How you can test it

Run pytest!

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2022

Codecov Report

Merging #45 (09fba98) into master (1302fb5) will increase coverage by 1.94%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master       #45      +/-   ##
===========================================
+ Coverage   98.05%   100.00%   +1.94%     
===========================================
  Files           4         4              
  Lines         103       103              
===========================================
+ Hits          101       103       +2     
+ Misses          2         0       -2     
Flag Coverage Δ
unittests 100.00% <ø> (+1.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
geojson_pydantic/geometries.py 100.00% <ø> (+1.51%) ⬆️
geojson_pydantic/features.py 100.00% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1302fb5...09fba98. Read the comment docs.

@vincentsarago
Copy link
Member

🙏

@vincentsarago vincentsarago merged commit 0a90617 into developmentseed:master Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants