Feat/validate json update #73
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
you can use https://pypi.org/project/singledispatchmethod/ for python <3.8 |
p1-dta
force-pushed
the
feat/validate_json_update
branch
from
db27a69
to
58b3138
Compare
|
I tried on local, same error for 3.7. |
geojson_pydantic/geometries.py
Outdated
| @@ -6,6 +6,7 @@ | |||
|
|
|||
| from pydantic import BaseModel, Field, ValidationError, validator | |||
| from pydantic.error_wrappers import ErrorWrapper | |||
| from singledispatchmethod import singledispatchmethod | |||
There was a problem hiding this comment.
this needs to be optional
is because the tests fails directly for 3.7 so GitHub actions kills all the other matrices |
|
This libraries fails on 3.7. I will investigate, but later this week. |
|
closing this. See #66 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I am changing
Geometryto increase readability of specific type validation.How I did it
functools.singledispatchmethod.How you can test it
Important notes
This is for
Python >= 3.9. python/cpython#83860