Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle human-generated non-OSM labels #32

Closed
lewfish opened this issue Jan 23, 2018 · 4 comments
Closed

Handle human-generated non-OSM labels #32

lewfish opened this issue Jan 23, 2018 · 4 comments
Labels
enhancement New feature or request

Comments

@lewfish
Copy link

lewfish commented Jan 23, 2018

I work on Raster Vision at Azavea and this library seems to handle some of the same functionality. We create object detection training chips from GeoTIFFs and human-generated GeoJSON label files, and I'm thinking about how to extend label-maker to do this. Do you think this would be in the scope of label-maker, or is the focus just on generating labels from OSM data? Handling human-generated label files would make the library more general and usable with pre-existing benchmark datasets, for instance. I saw that there's an issue (#13) for handling GeoTIFFs instead of TMS URLs, which would be step one. The next step would be handling GeoJSON labels, or GeoTIFFs in the case of segmentation. Or maybe the right approach is to convert our data into vector tiles which this library already handles.

@drewbo
Copy link
Contributor

drewbo commented Jan 23, 2018

@lewfish Raster Vision is great! I haven't checked it out deeply since the segmentation focus switch but will try to give it a read again soon.

I do think non-OSM labels are within the scope of label-maker. Until the tiling scheme is a bit more flexible, it's still easiest to read labels from vector tile sets, so the lowest friction approach right now is to use tippecanoe to convert GeoJSON to mbtiles and then run labels directly (skipping download). There are probably some naming or projection errors that will come up on the first attempts but I'm happy to help debug those and better support this use case going forward.

@drewbo drewbo closed this as completed in 8e221d8 Feb 24, 2018
drewbo added a commit that referenced this issue Feb 24, 2018
@drewbo
Copy link
Contributor

drewbo commented Feb 24, 2018

Closed the wrong issue with my commit

@drewbo drewbo reopened this Feb 24, 2018
@giswqs
Copy link
Contributor

giswqs commented Apr 11, 2018

I second this! I would be very nice if label-maker can support custom labels.

@drewbo drewbo added the enhancement New feature or request label Apr 17, 2018
@drewbo
Copy link
Contributor

drewbo commented Nov 5, 2018

Closed via #109

@drewbo drewbo closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants