Update argument list of download_tile_tms

[PallawiSinghal]

As get_image_function in utils.py returns either of get_tile_tif or get_tile_wms or download_tile_tms. All three functions should have the same argument signature.

Fixes issue #156

[wronk]

Thanks @PallawiSinghal, I think I introduced this bug with the new authentication here

[wronk]

LGTM, @drewbo, want to double check and merge?

[wronk]

Actually, I think we should solve this by adding imagery_offset to the kwargs dict rather than adding a new parameter to the image download functions. So this will involve

1. removing imagery_offset from download_tile_tms, get_tile_tif and get_tile_wms
2. Updating kwargs directly before it's passed on here
3. Pulling imagery_offset from the kwargs here

@PallawiSinghal, let me know if you are able to handle this. Otherwise I can. Best way is probably just to open a new PR if you don't know how to revert this commit within this branch.

[wronk]

☝️

[PallawiSinghal]

Thank you for your reply. I will do it as soon as possible , by EOD. Thanks and regards, Pallawi

…

On Tue, 10 Dec, 2019, 5:30 AM Mark Wronkiewicz, ***@***.***> wrote: Thanks @PallawiSinghal <https://github.com/PallawiSinghal>, I think I introduced this bug with the new authentication here <b5c865a#diff-f4145ef8eb8b8faa4e459bb126e8923d> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#157?email_source=notifications&email_token=AD54FIYWGDX2ITMVUNZRD6LQX3LYDA5CNFSM4JQ6QTK2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGLEG6I#issuecomment-563495801>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AD54FI73TJGEFK3422G7ZBDQX3LYDANCNFSM4JQ6QTKQ> .

[PallawiSinghal]

Made the changes

[wronk]

Nitpick, but pylint is complaining about a trailing whitespace here. I added the suggested change in the code.

Other than that, LGTM if the checks pass

[wronk]

Much thanks @PallawiSinghal!

Tests are still not passing, but I'm going to fix those right now. CircleCI checks aren't automatically being made visible (per #160), which is means nobody is getting the automatic feedback on their PRs