Check epsg:4326 bounds in layer creation #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a check on layer creation that the computed centroid of the input data is within the bounds of wgs84. This doesn't check the computed bounding box because that could wrap over the international date line and have values less than -180.
This is improved over the previous approach because previously we checked the final average of the centroid against wgs84, whereas now we check each layer individually. This is safer in case most layers are wgs84 but one is not. Also, it errors at layer creation, which is a much better time to error.
In the future, we could allow web-mercator coordinates as well (see https://deck.gl/docs/developer-guide/coordinate-systems) and this would have to be refactored to allow the larger range of coordinates.