Fix inferring number of rows per chunk #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use the
_rows_per_chunkattribute to determine the number of rows that are included in each Parquet chunk sent to the frontend. This is a layer-level construct because we need to ensure the main table and all accessors have exactly the same chunking, because each chunk is rendered independently as a separate deck.gl layerWe previously had issues where the number of rows per chunk was either not the same across all data objects within a layer, or alternatively a few cases (as with the ArcLayer) where we were accidentally initializing the number of rows per chunk to be
0, which let to an infinite loop intable.to_batches(max_chunksize=0).