NormalAccessor #376
NormalAccessor #376
Conversation
lonboard/traits.py
Outdated
| """Warning: Numpy array should be floating point type. | ||
| Converting to float32 point pyarrow array""" | ||
| ) | ||
| value = value.astype(np.float(pa.list_(pa.float32(), 3))) |
There was a problem hiding this comment.
This will fail; you want value.astype(np.float32). You can't pass a pyarrow type into a numpy function like this.
tests/test_traits.py
Outdated
| with pytest.raises(TraitError): | ||
| NormalAccessorWidget() | ||
|
|
||
| with pytest.raises(TraitError, match="expected 3 values if passed a tuple or list"): |
There was a problem hiding this comment.
The match here is tested against the error string, so if you're copying tests from above you might need to adjust the expected error string, or use the same error message in your code.
There was a problem hiding this comment.
Yes I will update these to match
tests/test_traits.py
Outdated
| # expected value is a numpy ndarray with two dimensions | ||
| # And size of the second dimension must be 3 i.e. `(N,3)` | ||
| with pytest.raises(TraitError, match="expected shape (N,3)"): | ||
| NormalAccessorWidget(value=np.array([1, 2], 3)) |
There was a problem hiding this comment.
All of these numpy calls will fail.
To construct a 2d numpy array you can do either
np.array([[1, 2], [3, 4]])which gives a 2x2 numpy array or
np.array([1, 2, 3, 4, 5, 6]).reshape(-1, 2)
which first creates a 1-dimensional array and then rearranges into a 2-d array, in this case of shape (3, 2).
There was a problem hiding this comment.
Right. I'll bring this as a general testing question because I thought that we were intentionally creating fail conditions and ensuring that the NormalAcc fails on these objects (like where the shape is just incorrect).
I see. Will continue updating the proper tests
There was a problem hiding this comment.
Yeah I mean that we want to test that passing a valid numpy array into NormalAccessorWidget fails. If the numpy creation fails before passing into our code, we haven't tested our own code yet.
Co-authored-by: Kyle Barron <kyle@developmentseed.org>
Co-authored-by: Kyle Barron <kyle@developmentseed.org>
Co-authored-by: Kyle Barron <kyle@developmentseed.org>
|
Thanks! I cleaned this up and updated the tests |
Adds NormalAccessor and draft tests
Respond to comments on #328 and move recent work here. Branch #328 will be deleted