Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preselect compare map from project explore page #128

Merged
merged 5 commits into from
Mar 6, 2024

Conversation

LanesGood
Copy link
Member

@LanesGood LanesGood commented Feb 28, 2024

This PR adds a "Publish" toggle and "compare" link to the export dropdown in the project page. The proposed workflow is intended to make it more straightforward to compare a map.

image

Screen.Recording.2024-02-28.at.3.58.21.PM.mov

Design decisions and workflow still to be refined, but PR opened for visibility and testing purposes. Contributes to #106.

Cc @vgeorge

@LanesGood
Copy link
Member Author

@geohacker or @vgeorge do you have any thoughts on the proposed changes in workflow here for the compare tool?

@geohacker
Copy link
Member

This is great idea @LanesGood!

@LanesGood LanesGood requested a review from vgeorge March 4, 2024 15:23
@LanesGood LanesGood marked this pull request as ready for review March 4, 2024 15:23
Copy link
Member

@vgeorge vgeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LanesGood this looks great. I didn't know you could pass location state properties via 😅. I just added some type fixes, this looks good to merge.

@LanesGood LanesGood merged commit 57fa286 into develop Mar 6, 2024
3 checks passed
@LanesGood LanesGood deleted the enhance/compare-preselect branch March 6, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants