add docs on how to run scoreboard locally #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @scisco do you think we should have instructions on running a local postgres without Docker? I think it would be simple for people that already have it installed. Could you also add an entry in the changelog? |
|
@kamicut I think for consistency we should just use the docker postgres. This PR didn't have any changes to the code the require a changelog update. |
|
I don't see how this is a consistency issue, since we don't require Docker before this PR and we should minimize dependencies for developers trying to contribute. I'll accept your changes and we can open this for another discussion. |
kamicut
approved these changes
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.