Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin morecantile dependency to < v3.0.0 #389

Merged

Conversation

robintw
Copy link
Contributor

@robintw robintw commented Oct 13, 2021

There have been some major changes in morecantile in version 3.0.0 (see https://github.com/developmentseed/morecantile/issues/620). This means that morecantile has switched to using CRS objects from pyproj rather than CRS objects from rasterio.

This was causing titiler to fail when installed with morecantile 3.0.0 - which was happening automatically when I created a new environment and just installed titiler, because there was no version specification in the setup.py.

This PR adds a version spec to the dependency, ensuring that morecantile stays below version 3.0.0.

(I did also try pinning morecantile to at least version 3.0.0, and updating the titiler code to use the pyproj CRS objects - but i got warnings from pip that various other packages had pinned morecantile to <3.0.0, so it's probably best to stick with that for the moment.)

@robintw robintw changed the title Fix morecantile dependency to < v3.0.0 Pin morecantile dependency to < v3.0.0 Oct 13, 2021
@vincentsarago
Copy link
Member

(I did also try pinning morecantile to at least version 3.0.0, and updating the titiler code to use the pyproj CRS objects - but i got warnings from pip that various other packages had pinned morecantile to <3.0.0, so it's probably best to stick with that for the moment.)

Yes that won't work because rio-tiler 2.0, rio-cogeo 2.0 and cogeo-mosaic require morecantile <3.0

We've release rio-cogeo 3.0 which depends on morecantile>=3.0 but rio-tiler will come later cogeotiff/rio-tiler#426

@vincentsarago vincentsarago merged commit 8b39bd4 into developmentseed:master Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants