Updating titiler base image to bitnami/python:3.9 in Dockerfile and CI #520
Conversation
FischerLGLN
force-pushed
the
master
branch
3 times, most recently
from
dc2b225
to
92da41e
Compare
dockerfiles/Dockerfile.gunicorn
Outdated
| FROM bitnami/python:${PYTHON_VERSION} | ||
| RUN apt update && apt upgrade -y \ | ||
| && apt install curl -y \ | ||
| && rm -rf /var/lib/apt/lists/* |
There was a problem hiding this comment.
@FischerLGLN Tiangolo image has more than just gunicorn
I guess the easiest way might just to update https://github.com/vincentsarago/containers/tree/main/uvicorn-gunicorn with the bitnami docker images.
There was a problem hiding this comment.
You're fast.
Do you mean this file?
https://github.com/vincentsarago/containers/blob/main/uvicorn-gunicorn/python3.9.dockerfile
I think its mainly the start.sh and start-reload.sh files as well as the guvicorn config, but they aren't needed in a kubernetes platform.
Idea:
We just say guvicorn is for dev and normal use and the uvicorn image is for kubernetes.
I would handle in this PR just the Uvicorn Part and change in kubernetes deployment.
There was a problem hiding this comment.
I would handle in this PR just the Uvicorn Part and change in kubernetes deployment.
sounds good to me
There was a problem hiding this comment.
@vincentsarago Gunicorn is semantically untouched and with this PR I get my updated uvicorn :)
There was a problem hiding this comment.
FischerLGLN
changed the title
|
@vincentsarago Oh wow, I will add a version bump. I suggest bumping 1.0.0 to 1.1.0 |
|
@emmanuelmathot FYI: Bumped your titiler helm chart as part of this PR, linting is okay. |
|
Indeed, since the chart has changed, the version as well. thx! |
|
@vincentsarago Hi, can this PR be merged? Thanks! |
it alongside normal gunicorn image. Signed-off-by: Maik Fischer <maik.fischer@lgln.niedersachsen.de>
|
@vincentsarago Looking forward to see another package for uvicorn created through master commit: https://github.com/developmentseed/titiler/pkgs/container/titiler |
Signed-off-by: Maik Fischer maik.fischer@lgln.niedersachsen.de
Available PR templates
Issue: #519
Added a bitnami hardened Dockerfile to address security issues.
Python 3.10 is used, since I haven't found build problems with Python 3.10.
I cannot test the ci part, but I've built the image manually and could successful deliver images through titiler.