Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter 3.14.4, AGP 8, Dart 3, sensors_plus: ^3.0.3 #29

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

ciriousjoker
Copy link

@ciriousjoker ciriousjoker commented Sep 20, 2023

Essentially this PR combines the open version-update PRs into one and adds some general maintenance on top.

@ziqq I know it's a waste to essentially recreate your PR, but we need a stable fork that we can rely on anyway, so here it is.

  shake:
    git:
      url: https://github.com/dieringe/shake
      ref: dieringe

@deven98 Do you plan on reviewing the open PRs anytime soon?

@deven98
Copy link
Owner

deven98 commented Sep 20, 2023

Hi Philipp,

Thanks so much for the PR. My apologies for this repository being unmaintained for a bit, I was dealing with a few personal issues. I will have this PR reviewed and the new version launched by tomorrow.

Thanks so much for the contribution and I'll do more to support the repo going ahead.

@ciriousjoker
Copy link
Author

Np. When reviewing, checking the lowest flutter version you want to support makes the most sense (if u had to pick one), but take your time (esp with personal issues!)

@juliansteenbakker
Copy link

Hi @deven98, if you need any help maintaining the repo you can add me as a contributor.

@simplenotezy
Copy link

@deven98 can you perhaps bump to sensors_plus to 4? So we can use flutter 3.16

@simplenotezy
Copy link

@deven98 I've submitted a PR for you, that enables support for 3.16 flutter version by supporting sensors_plus v4:

dieringe#1

@ciriousjoker
Copy link
Author

@simplenotezy I just built our project with Flutter 3.16.2 & the current state of the PR (ie sensors_plus v3.0.3) and everything seems to build & run just fine.

In what way was v3 incompatible with Flutter 3.16? Which 3.16.x did you use?

@leonidlist
Copy link

Hello, @deven98! Any news with reviewing this one? Or maybe you need help with reviewing it?

@nivisi
Copy link

nivisi commented Apr 2, 2024

Hi @deven98. Kindly pinging to remind that the users of this package still wait for a new version to come in. Do you need any help with updating the package?

@nicklbaert
Copy link

Hi @deven98, are there any plans on merging this at some point? Is there some way to assist you?

@ciriousjoker
Copy link
Author

Due to the old version of sensors_plus, people have started to run into issues like this one:

The solution is to upgrade the sensors_plus version. Since this package seems to be dead anyway, we've decided to switch to shake_gesture. Our fork will still be available for the foreseeable future, in case someone decides to pick this up again.

@FeodorFitsner
Copy link

FeodorFitsner commented Aug 9, 2024

You can just add ShakeDetector class in your app codebase. This package is just a single class.

@ciriousjoker
Copy link
Author

@FeodorFitsner I saw that too, but with shake_gesture, there's no dependency to sensors_plus at all. No idea what's better here, but since they're all pretty much interchangeable anyway it probably doesn't matter what you pick in any given situation. Our decision was: fewer and smaller dependencies is better, but "id rather have a bigger, but well maintained dependency" is definitely also a valid approach. I guess we'll see what the future brings :)

@FeodorFitsner
Copy link

Will take a look at shake_gesture. Also, there is Feedback service introduced in Flutter 3.24. Don't know if it provides the same/more/less functionality though.

@FeodorFitsner
Copy link

Scratch that - it's for haptic feedback 🫣

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants