Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update tools path to bin for newer mkl (2020.1.217) #51

Merged
merged 1 commit into from May 23, 2021
Merged

update tools path to bin for newer mkl (2020.1.217) #51

merged 1 commit into from May 23, 2021

Conversation

acxz
Copy link
Contributor

@acxz acxz commented May 23, 2021

With the newer intel mkl versions the path for tools has changed to bin. I am sure a better solution can be thought of that uses the version information. This is a patch solution for now.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.105% when pulling 9fa5180 on acxz:bin-tools into 0d40c53 on devernay:master.

@devernay devernay merged commit e69d159 into devernay:master May 23, 2021
@acxz acxz deleted the bin-tools branch May 24, 2021 13:40
@xantares
Copy link
Contributor

xantares commented Jun 15, 2021

your patch may break older mkl installs
I think find_program is the way to go, testing both locations, can you try that:

find_program (MKL_LINK_TOOL NAMES mkl_link_tool HINTS ${MKL_ROOT_DIR}/bin ${MKL_ROOT_DIR}/tools)

also, I think it takes care of the .exe extension that is appended manually just after the set line.

@acxz
Copy link
Contributor Author

acxz commented Jun 15, 2021

Definitely it will break older mkl installs.

Yeah find_program is a great suggestion.

Edit: It worked for me, here is the PR for it #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants