support scons 3.1 (using python 3.9) on MSYS2/MinGW #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that python2+mako is still needed.
devernay
approved these changes
Nov 7, 2021
|
a newer Mesa is OK, but the biggest concern was threas-safety of the gallium driver, which was handled by the largest path in the collection. Maybe it was fixed in later iterations of OSMesa, but this has to be tested (A highly multi-threaded Natron instance with software OpenGL rendering is a good test case). Feel free to provide support for later OSMesa versions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that python2+mako is still needed.
This is a BIG patch, maybe better to move to a newer Mesa? Anyway, these patches are needed to build osmesa on latest MSYS2/MinGW.
Also note that scons has been removed in later versions of Mesa (they now use meson).