Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: removed redrawBackgroundChartArea and improved performace #102

Merged
merged 4 commits into from
Dec 22, 2023
Merged

feat: removed redrawBackgroundChartArea and improved performace #102

merged 4 commits into from
Dec 22, 2023

Conversation

KirillBobkov
Copy link
Contributor

@KirillBobkov KirillBobkov commented Dec 15, 2023 •
edited

image

@DeltaZN
Copy link
Contributor

DeltaZN commented Dec 15, 2023 •
edited

Am I right that right now the gradient won't be applied to axis? As far as I remember there was an explicit req to apply gradient to axis as well

@KirillBobkov
Copy link
Contributor Author

KirillBobkov commented Dec 18, 2023 •
edited

Am I right that right now the gradient won't be applied to axis? As far as I remember there was an explicit req to apply gradient to axis as well

yes, gradient won't be applied in default chart config. But if user will set transparent backgrounds for YAxis and XAxis, gradient will be applied

@KirillBobkov KirillBobkov reopened this Dec 18, 2023
@KirillBobkov
Merge remote-tracking branch 'origin/master' into feat-improve-perfor…
ad50a89 
…mace-by-deleting-redraw-background-canvas-area
@KirillBobkov
feat: removed redrawBackgroundChartArea and improved performace with …
46319bf 
…native ctx.rect // modev back for label description
@KirillBobkov KirillBobkov merged commit 5fa9dad into master Dec 22, 2023
2 checks passed
@disyakidneyshot disyakidneyshot added the enhancement New feature or request label Dec 26, 2023
@disyakidneyshot disyakidneyshot deleted the feat-improve-performace-by-deleting-redraw-background-canvas-area branch December 26, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Keelaro1 Keelaro1 Keelaro1 approved these changes

@DeltaZN DeltaZN DeltaZN approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@KirillBobkov @DeltaZN @Keelaro1 @disyakidneyshot