enhancement: dont draw hittest when viewport animation is active #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested with histogram chart type and 1h period, if zoom out to 1000 candles even single chart makes performance bad :) 
|
| @@ -61,6 +63,14 @@ export class HitTestCanvasModel extends CanvasModel { | |||
| initCanvasWithConfig(this, chartConfig); | |||
| canvas.style.visibility = 'hidden'; | |||
| this.enableUserControls(); | |||
| this.canvasAnimation.animationIntervalIdSubject.subscribe(() => { | |||
There was a problem hiding this comment.
memory leak, no unsubsrcribe call
Keelaro1
commented
Jan 16, 2024
KirillBobkov
requested changes
Jan 17, 2024
|
Please, add new profiler screenshot after new changes will be applied |
|
The new result, single chart, candle chart type, 1h period, added 5 studies (Average Directional Index), maximum zoom out: 
|
disyakidneyshot
requested changes
Jan 18, 2024
…into animation-hittest-draw-optimization
…com/devexperts/dxcharts-lite into animation-hittest-draw-optimization
disyakidneyshot
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.