fix: replace function constructor for date formatter with arrow function #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirillBobkov
requested changes
Mar 12, 2024
disyakidneyshot
force-pushed
the
remove-date-formatter-function-constructor
branch
from
a912dab
to
1b20f7e
Compare
…github.com/devexperts/dxcharts-lite into remove-date-formatter-function-constructor
|
Rechecked performance with old and new format methods when initially load the chart (no timezones loaded): the values are in general the same: Old formatter: values are 50.37ms and 39.50ms New formatter: values are 48ms and 23ms 
|
disyakidneyshot
approved these changes
Mar 27, 2024
KirillBobkov
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.