fix: resizer and baseline conflict with chart panning #156
Conversation
| @@ -75,6 +76,7 @@ export abstract class ChartBaseElement implements ChartEntity { | |||
| this.deactivate(); | |||
| this._state = 'disabled'; | |||
| } | |||
| this.entities.forEach(comp => comp.disable()); | |||
There was a problem hiding this comment.
Couldn't understand why disable method calls this.deactivate, and this.deactivate calls deactivate function of all child entities
Because of that we basically never call 'disable' and 'enable' functions of child entities which leads to incorrect behavior
There was a problem hiding this comment.
Nice question, need some time to figure it out
There was a problem hiding this comment.
I should say for me disabled state and disable <-> enable transitions are completely useless
They were added a loooong time ago and I think we can mark them as deprecated. Looks like activate and deactivate do exactly the same
There was a problem hiding this comment.
Turned out they are not the same, using deactivate to child entities didn't make YDragNDrop entities of chart area pan "disabled" (we still can move chart vertically), only disable makes it work as expected
| @@ -75,6 +76,7 @@ export abstract class ChartBaseElement implements ChartEntity { | |||
| this.deactivate(); | |||
| this._state = 'disabled'; | |||
| } | |||
| this.entities.forEach(comp => comp.disable()); | |||
There was a problem hiding this comment.
I should say for me disabled state and disable <-> enable transitions are completely useless
They were added a loooong time ago and I think we can mark them as deprecated. Looks like activate and deactivate do exactly the same
disyakidneyshot
force-pushed
the
fix-resizer-vertical-behavior
branch
from
611a29d
to
0535e07
Compare
No description provided.