fix: volume dynamic object behavior #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KirillBobkov
requested changes
Apr 11, 2024
| // check if the volumes dynamic object is already added | ||
| const position = this.dynamicObjectsComponent.model.getObjectPosition(this.volumesModel.id); | ||
| if (position !== -1) { | ||
| if (position === -1) { | ||
| this.dynamicObjectsComponent.model.addObject(this.volumesDynamicObject); |
There was a problem hiding this comment.
Maybe it is better for code reading to restore an object destructure? Because it is difficult to track where paneId is changed.
Or we can make a setter before adding object to this.dynamicObjectsComponent.model and after that use this.volumesDynamicObject
But, if this.config.components.volumes.visible === false, we delete it from this.dynamicObjectsComponent.model, but we still have this.volumesDynamicObject in memory.
In general, looks like it is unnecessarily to keep it in this class, and use getter/setter for it
KirillBobkov
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.